[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation t
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles. |
Date: |
Tue, 18 Oct 2011 15:25:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
On 10/18/2011 01:28 PM, Blue Swirl wrote:
>> > + static const char * const fregnames[32] = {
>> > + "f0", "f2", "f4", "f6", "f8", "f10", "f12", "f14",
>> > + "f16", "f18", "f20", "f22", "f24", "f26", "f28", "f30",
>> > + "f32", "f34", "f36", "f38", "f40", "f42", "f44", "f46",
>> > + "f48", "f50", "f52", "f54", "f56", "f58", "f60", "f62",
> Shouldn't these become "d0" etc?
>
That's what I had at first, but then after looking at the dumps for
a few additional patches went back and changed it. My feeling is
that these should match the disassembler, and it always uses f%d.
>> - for (i = 0; i < TARGET_FPREGS; i++)
>> - cpu_fpr[i] = tcg_global_mem_new_i32(TCG_AREG0,
>> + for (i = 0; i < TARGET_DPREGS; i++)
> Please add braces.
>
Sure.
r~
- Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters instead of dt0/1 temporaries., (continued)
- [Qemu-devel] [PATCH 11/21] target-sparc: Do exceptions management fully inside the helpers., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 13/21] target-sparc: Implement PDIST., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 12/21] sparc-linux-user: Handle SIGILL., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 15/21] target-sparc: Implement EDGE* instructions., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 14/21] target-sparc: Implement fpack{16, 32, fix}., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 10/21] tcg: Optimize some forms of deposit., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 08/21] target-sparc: Undo cpu_fpr rename., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 20/21] sparc-linux-user: Add some missing syscall numbers, Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 07/21] target-sparc: Extract float128 move to a function., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 21/21] sparc-linux-user: Enable NPTL, Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 03/21] target-sparc: Add accessors for double-precision fpr access., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 18/21] target-sparc: Tidy fpack32., Richard Henderson, 2011/10/18