qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters ins


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters instead of dt0/1 temporaries.
Date: Tue, 18 Oct 2011 13:07:54 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

On 10/18/2011 01:04 PM, Blue Swirl wrote:
>> > -    F_HELPER(name, d)                                           \
>> > +    float64 helper_f ## name ## d (CPUState * env, float64 src1,\
>> > +                                   float64 src2)                \
>> >     {                                                           \
>> > -        DT0 = float64_ ## name (DT0, DT1, &env->fp_status);     \
>> > +        return float64_ ## name (src1, src2, &env->fp_status);  \
>> >     }                                                           \
> Could we call float64_##name() directly from generated code and avoid
> the wrapper? Translator could generate &env->fp_status and in other
> cases that could be passed around instead of env.
> 

The helper.h machinery isn't set up for that.  Also, see patch 11.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]