|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set. |
Date: | Fri, 05 Aug 2011 11:34:41 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 08/05/2011 09:53 AM, Anthony Liguori wrote: >> + if (val& E1000_CTRL_RST) { > > You'll break some GCCs with -Wall -Werror with this. Please do: > > if ((val & E1000_CTRL_RST)) { Err, really? What versions? I don't recall that ever being true. r~
[Prev in Thread] | Current Thread | [Next in Thread] |