[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set. |
|
Date: |
Fri, 5 Aug 2011 19:44:02 +0100 |
On 5 August 2011 17:53, Anthony Liguori <address@hidden> wrote:
> You'll break some GCCs with -Wall -Werror with this. Please do:
>
> if ((val & E1000_CTRL_RST)) {
Hmm? There's lots of examples of that in the codebase:
$ git grep 'if ([a-zA-Z]* & ' | wc -l
1558
'=' (assignment) needs those extra braces, but logical
ops don't AFAIK.
-- PMM