[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga |
Date: |
Wed, 29 Jun 2011 11:31:22 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jun 29, 2011 at 11:22:05AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >The driver may change us to vga mode and still issue a QXL_IO_LOG,
> >which we can easily support.
>
> >@@ -1001,9 +1001,9 @@ static void ioport_write(void *opaque, uint32_t addr,
> >uint32_t val)
> >- case QXL_IO_LOG:
> > case QXL_IO_CREATE_PRIMARY_ASYNC:
> > case QXL_IO_UPDATE_IRQ:
> >+ case QXL_IO_LOG:
> > break;
>
> That is a NOP, and it also doesn't apply. It isn't the only patch
> which doesn't apply cleanly, looks like your series isn't based on
> upstream/master ...
Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you
have other comments?
Unrelated, but have you looked at the async patches that I sent, and yonit's
comments?
- (me) catch EINTR and EAGAIN in async thread read
- (yonit) reset surfaces count and surfaces when doing destroy_all
And I think there were some others I forget.
>
> cheers,
> Gerd
[Qemu-devel] [PATCH v2] qxl: abort on panic instead of exit, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl-logger: add timestamp to command log, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl: update and add debug prints, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl: add dev id to guest prints, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl: add io_port_to_string, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl: update revision to QXL_REVISION_STABLE_V10, Alon Levy, 2011/06/24
[Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes, Alon Levy, 2011/06/24