qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_pri


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output
Date: Wed, 29 Jun 2011 11:26:04 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Gerd Hoffmann <address@hidden> writes:

>   Hi,
>
>> Erm, I'm not aware that my qdev bool patch got committed yet, so the
>> question of how to parse/print bool properties (on/off vs. yes/no) is
>> still undecided, no comments so far. It would be entirely possible to
>> let the author decide that on a case-by-case basis by using different
>> property type enums for the same 'bool' type.
>
> Just accept both "on" and "yes" for true and both "off" and "no" for false?
>
> For printing we'll have to pick one though.  I'd tend to pick on/off
> as I guess most properties will enable or disable some feature.  Or
> have the two enums ...

KISS.  Let's stick to one way to print bools.

If on/off carries so much meaning that it offends aesthetic
sensibilities too much, sidestep meaning and use 1/0.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]