|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""' |
Date: | Mon, 14 Feb 2011 06:10:04 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 |
On 02/14/2011 04:57 AM, Gerd Hoffmann wrote:
On 01/31/11 21:43, Anthony Liguori wrote:commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in thechange vnc password command that changed the behavior of setting the VNCpassword to an empty string from disabling login to disabling authentication.This commit refactors the code to eliminate this overloaded semantics invnc_display_password and instead introduces the vnc_display_disable_login. The monitor implementation then determines the behavior of an empty or missingstring.Hmm, now about simply never ever changing vs->auth?
If auth is none and you do a vnc change password "" then if we don't set vs->auth to vnc, it won't have the desired effect. I really dislike the semantics of this command but that was a past mistake.
Regards, Anthony Liguori
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |