[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'chang
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""' |
Date: |
Thu, 3 Feb 2011 17:02:40 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 03, 2011 at 10:35:51AM -0600, Anthony Liguori wrote:
> On 02/03/2011 10:29 AM, Daniel P. Berrange wrote:
> >On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote:
> >>commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in
> >>the
> >>change vnc password command that changed the behavior of setting the VNC
> >>password to an empty string from disabling login to disabling
> >>authentication.
> >>
> >>This commit refactors the code to eliminate this overloaded semantics in
> >>vnc_display_password and instead introduces the vnc_display_disable_login.
> >> The
> >>monitor implementation then determines the behavior of an empty or missing
> >>string.
> >Personally I think this is a little overkill& just reverting the
> >original patch was fine, but from a functional POV your patch
> >produces the same results, so I won't argue.
>
> For 0.15, I'd like to introduce a new set of commands such that we
> don't multiplex the change command anymore. This refactoring lays
> the ground work for that.
>
> For instance, if you created a block device with the name 'vnc',
> you'd get very unexpected results! Multiplexing based on special
> values on top of existing commands is pretty evil.
Doesn't Gerd's 'set_password' command already replace the functionality
of the 'change vnc' command. So we should likely declare 'change vnc'
as deprecated in 0.14 and remove it in 0.16
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|