[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver option
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options |
|
Date: |
Mon, 06 Dec 2010 11:20:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/06/10 10:32, Stefan Hajnoczi wrote:
> On Mon, Dec 6, 2010 at 8:17 AM, <address@hidden> wrote:
>> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv)
>>
>> out_filename = argv[argc - 1];
>>
>> + if (options && !strcmp(options, "?")) {
>> + ret = print_block_option_help(out_filename, out_fmt);
>> + goto out2;
>> + }
>> +
>> if (bs_n > 1 && out_baseimg) {
>> error("-B makes no sense when concatenating multiple input images");
>> return 1;
>
> Why goto out2 and not just return like the bs > 1 && out_baseimg check?
It is cleaner, I'd rather convert the bs_n test to do it too.
Cheers,
Jes