qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/3] Cleanup qemu-img code


From: Jes . Sorensen
Subject: [Qemu-devel] [PATCH v2 0/3] Cleanup qemu-img code
Date: Mon, 6 Dec 2010 09:17:33 +0100

From: Jes Sorensen <address@hidden>

Hi,

These patches moves the handling of block help printing to shared
code, which allows the "?" detection to happen early in the parsing,
instead of half way down img_create() and img_convert(). I would like
to see this happen as I would like to pull some of the code out of
img_create() and into block.c so it can be shared with qemu and
qemu-img.

The formatting patch is solely because the third patch wanted to
change code next to the badly formatted code, and I didn't want to
pollute the patch with the formatting fixed.

The third patch fixes qemu-img to exit on detection of unknown options
instead of continuing with a potentially wrong set of arguments.

New in v2: Add missing free_option_parameters() and handle the help()
case in the general switch() statements for the getopt() output.

Cheers,
Jes

Jes Sorensen (3):
  Consolidate printing of block driver options
  Fix formatting and missing braces in qemu-img.c
  Fail if detecting an unknown option

 qemu-img.c |  132 ++++++++++++++++++++++++++++++++++++++++++++----------------
 1 files changed, 97 insertions(+), 35 deletions(-)

-- 
1.7.3.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]