qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch table


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables
Date: Wed, 29 Sep 2010 13:41:01 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Anthony Liguori <address@hidden> writes:

> On 09/16/2010 03:20 PM, Luiz Capitulino wrote:
>> The subject says it all: with this series applied we'll get different
>> dispatch tables for HMP and QMP, which has the side effect of making
>> QMP commands (such as qmp_capabilities) disappear from HMP's scope.
>>
>> This is also the beginning of the Monitor's redesign, which aims to
>> separate QMP, HMP and common code.
>>
>> There's a penalty, though. We're going to get a bit of duplication
>> during the process, like duplicated handlers entries in the
>> dispatch tables.
>>
>> We'll need more separation and a proper internal QMP interface to
>> solve that...
>>    
>
> Acked-by: Anthony Liguori <address@hidden>
>
> It all looks pretty straight forward.  Nice work!

Agree.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]