[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch table
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables |
Date: |
Wed, 29 Sep 2010 13:41:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Anthony Liguori <address@hidden> writes:
> On 09/16/2010 03:20 PM, Luiz Capitulino wrote:
>> The subject says it all: with this series applied we'll get different
>> dispatch tables for HMP and QMP, which has the side effect of making
>> QMP commands (such as qmp_capabilities) disappear from HMP's scope.
>>
>> This is also the beginning of the Monitor's redesign, which aims to
>> separate QMP, HMP and common code.
>>
>> There's a penalty, though. We're going to get a bit of duplication
>> during the process, like duplicated handlers entries in the
>> dispatch tables.
>>
>> We'll need more separation and a proper internal QMP interface to
>> solve that...
>>
>
> Acked-by: Anthony Liguori <address@hidden>
>
> It all looks pretty straight forward. Nice work!
Agree.
- [Qemu-devel] [PATCH 10/18] QMP: Introduce query commands dispatch table, (continued)
- [Qemu-devel] [PATCH 10/18] QMP: Introduce query commands dispatch table, Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 11/18] QMP: Simplify do_info_commands(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 14/18] Monitor: Drop monitor_cmd_user_only(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 13/18] Monitor: Drop QMP info from the qemu-monitor.hx file, Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 15/18] Monitor: Rename monitor_handler_ported(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 16/18] Monitor: Rename monitor_handler_is_async(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 17/18] Monitor: Directly call QObject handlers, Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 12/18] QMP: Small cleanup in handle_qmp_command(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 18/18] QMP: Introduce qmp_call_cmd(), Luiz Capitulino, 2010/09/16
- Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables, Anthony Liguori, 2010/09/21
- Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables,
Markus Armbruster <=