|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables |
Date: | Tue, 21 Sep 2010 07:56:16 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100826 Lightning/1.0b1 Thunderbird/3.0.7 |
On 09/16/2010 03:20 PM, Luiz Capitulino wrote:
The subject says it all: with this series applied we'll get different dispatch tables for HMP and QMP, which has the side effect of making QMP commands (such as qmp_capabilities) disappear from HMP's scope. This is also the beginning of the Monitor's redesign, which aims to separate QMP, HMP and common code. There's a penalty, though. We're going to get a bit of duplication during the process, like duplicated handlers entries in the dispatch tables. We'll need more separation and a proper internal QMP interface to solve that...
Acked-by: Anthony Liguori <address@hidden> It all looks pretty straight forward. Nice work! Regards, Anthony Liguori
--- Makefile | 2 +- Makefile.target | 7 +- monitor.c | 357 ++++++++----- monitor.h | 1 - qemu-monitor-qmp.hx | 1541 +++++++++++++++++++++++++++++++++++++++++++++++++++ qemu-monitor.hx | 1361 +--------------------------------------------- 6 files changed, 1774 insertions(+), 1495 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |