[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn
From: |
Chen Cao |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn |
Date: |
Tue, 24 Aug 2010 20:16:32 +0800 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Aug 24, 2010 at 03:04:44PM +0300, Avi Kivity wrote:
> On 08/24/2010 03:07 PM, Isaku Yamahata wrote:
> >On Tue, Aug 24, 2010 at 02:42:18PM +0300, Avi Kivity wrote:
> >> On 08/24/2010 02:35 PM, Isaku Yamahata wrote:
> >>>Add Cc: address@hidden
> >>>
> >>>MAX_PCI_SLOTS should be in pci.h instead of qdev.h?
> >>>And the name should be start with PCI_ prefix for consistency?
> >>>
> >>>Except that, the patches look okay.
> >>>
> >>These aren't slots, are they? They are functions.
> >The function checks if given $slot.$fn (or $slot) is valid.
> >So it's slots. max 32.
>
> + assert(devfn< PCIBUS_MAX_DEVICES);
>
>
> Looks like we're comparing a function number to PCIBUS_MAX_DEVICES.
>
PCIBUS_MAX_DEVICES is the size of PCIBus.devices[], I have added it in
the first patch at the defination of struct PCIBus, line 50 hw/pci.c.
so i think the better name of the macro should be PCIBUS_MAX_FN,
right?
Ken
> --
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
- [Qemu-devel] [PATCH 1/3] PCI: define max devices number on PCIBus as PCIBUS_MAX_DEVICES in pci.h, Ken CC, 2010/08/24
- [Qemu-devel] [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus, Ken CC, 2010/08/24
- [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Ken CC, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Isaku Yamahata, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Isaku Yamahata, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Isaku Yamahata, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn,
Chen Cao <=
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24