[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn
From: |
Isaku Yamahata |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn |
Date: |
Tue, 24 Aug 2010 20:35:21 +0900 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
Add Cc: address@hidden
MAX_PCI_SLOTS should be in pci.h instead of qdev.h?
And the name should be start with PCI_ prefix for consistency?
Except that, the patches look okay.
thanks,
On Tue, Aug 24, 2010 at 02:49:27PM +0800, Ken CC wrote:
> Define MAX_PCI_SLOTS as 0x1f, if pci addr provided from command line
> is bigger than 0x1f, return error -EINVAL.
>
> 0x1f << 3 | 7 == 255 (PCIBUS_MAX_DEVICES - 1)
>
> Signed-off-by: Ken CC <address@hidden>
> ---
> hw/qdev-properties.c | 2 ++
> hw/qdev.h | 3 +++
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..96d814c 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -514,6 +514,8 @@ static int parse_pci_devfn(DeviceState *dev, Property
> *prop, const char *str)
> return -EINVAL;
> }
> }
> + if (slot > MAX_PCI_SLOTS)
> + return -EINVAL;
> if (str[n] != '\0')
> return -EINVAL;
> if (fn > 7)
> diff --git a/hw/qdev.h b/hw/qdev.h
> index 678f8b7..fcfe52e 100644
> --- a/hw/qdev.h
> +++ b/hw/qdev.h
> @@ -7,6 +7,9 @@
> #include "qemu-char.h"
> #include "qemu-option.h"
>
> +
> +#define MAX_PCI_SLOTS 0x1f
> +
> typedef struct Property Property;
>
> typedef struct PropertyInfo PropertyInfo;
>
>
--
yamahata
- [Qemu-devel] [PATCH 1/3] PCI: define max devices number on PCIBus as PCIBUS_MAX_DEVICES in pci.h, Ken CC, 2010/08/24
- [Qemu-devel] [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus, Ken CC, 2010/08/24
- [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Ken CC, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn,
Isaku Yamahata <=
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Isaku Yamahata, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Isaku Yamahata, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Chen Cao, 2010/08/24
- Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn, Avi Kivity, 2010/08/24