[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/18] vnc: tight: remove a memleak in send_jpeg_
From: |
Corentin Chary |
Subject: |
[Qemu-devel] [PATCH v2 07/18] vnc: tight: remove a memleak in send_jpeg_rect() |
Date: |
Wed, 7 Jul 2010 20:57:55 +0200 |
buf was never freed.
Signed-off-by: Corentin Chary <address@hidden>
---
ui/vnc-enc-tight.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ade8e5f..4ff88a8 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1247,8 +1247,6 @@ static int send_jpeg_rect(VncState *vs, int x, int y, int
w, int h, int quality)
if (ds_get_bytes_per_pixel(vs->ds) == 1)
return send_full_color_rect(vs, w, h);
- buf = qemu_malloc(w * 3);
- row[0] = buf;
buffer_reserve(&vs->tight_jpeg, 2048);
cinfo.err = jpeg_std_error(&jerr);
@@ -1270,10 +1268,13 @@ static int send_jpeg_rect(VncState *vs, int x, int y,
int w, int h, int quality)
jpeg_start_compress(&cinfo, true);
+ buf = qemu_malloc(w * 3);
+ row[0] = buf;
for (dy = 0; dy < h; dy++) {
jpeg_prepare_row(vs, buf, x, y + dy, w);
jpeg_write_scanlines(&cinfo, row, 1);
}
+ qemu_free(buf);
jpeg_finish_compress(&cinfo);
jpeg_destroy_compress(&cinfo);
--
1.7.1
- [Qemu-devel] [PATCH v2 00/18] [PATCH v2 00/18] VNC Updates for 0.13, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 03/18] vnc: add lossy option, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 02/18] vnc: JPEG should be disabled if the client don't set tight quality, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 05/18] vnc: rename vnc-encoding-* vnc-enc-*, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 04/18] ui: move all ui components in ui/, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 07/18] vnc: tight: remove a memleak in send_jpeg_rect(),
Corentin Chary <=
- [Qemu-devel] [PATCH v2 01/18] vnc: tight: add JPEG and gradient subencoding with smooth image detection, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 09/18] vnc: tight: specific zlib level and filters for each compression level, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 12/18] vnc: fix tight png memory leak, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 06/18] vnc: tight: don't forget do at the last color, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 16/18] vnc: tight: fix rgb_prepare_row, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 10/18] vnc: tight: stop using qdict for palette stuff, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 17/18] vnc: tight: split send_sub_rect, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 13/18] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 18/18] vnc: better default values for VNC options, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 15/18] vnc: add missing lock for vnc_cursor_define(), Corentin Chary, 2010/07/07