[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 09/18] vnc: tight: specific zlib level and filter
From: |
Corentin Chary |
Subject: |
[Qemu-devel] [PATCH v2 09/18] vnc: tight: specific zlib level and filters for each compression level |
Date: |
Wed, 7 Jul 2010 20:57:57 +0200 |
Disable png filters for lower compression levels. This should lower
the CPU consumption and reduce encoding time.
This isn't in tight_conf because:
* tight_conf structure must not change, because it's shared with other
tight implementations (libvncserver, etc..).
* it'd exceed the 80 col limit.
* PNG_ macros are only defined if CONFIG_VNC_PNG is defined
Signed-off-by: Corentin Chary <address@hidden>
---
ui/vnc-enc-tight.c | 19 ++++++++++++++++++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index cc57c26..e627e00 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -73,6 +73,21 @@ static int tight_send_framebuffer_update(VncState *vs, int
x, int y,
int w, int h);
#ifdef CONFIG_VNC_PNG
+static const struct {
+ int png_zlib_level, png_filters;
+} tight_png_conf[] = {
+ { 0, PNG_NO_FILTERS },
+ { 1, PNG_NO_FILTERS },
+ { 2, PNG_NO_FILTERS },
+ { 3, PNG_NO_FILTERS },
+ { 4, PNG_NO_FILTERS },
+ { 5, PNG_ALL_FILTERS },
+ { 6, PNG_ALL_FILTERS },
+ { 7, PNG_ALL_FILTERS },
+ { 8, PNG_ALL_FILTERS },
+ { 9, PNG_ALL_FILTERS },
+};
+
static int send_png_rect(VncState *vs, int x, int y, int w, int h,
QDict *palette);
@@ -1425,7 +1440,8 @@ static int send_png_rect(VncState *vs, int x, int y, int
w, int h,
png_infop info_ptr;
png_colorp png_palette = NULL;
size_t offset;
- int level = tight_conf[vs->tight_compression].raw_zlib_level;
+ int level = tight_png_conf[vs->tight_compression].png_zlib_level;
+ int filters = tight_png_conf[vs->tight_compression].png_filters;
uint8_t *buf;
int dy;
@@ -1444,6 +1460,7 @@ static int send_png_rect(VncState *vs, int x, int y, int
w, int h,
png_set_write_fn(png_ptr, (void *) vs, png_write_data, png_flush_data);
png_set_compression_level(png_ptr, level);
+ png_set_filter(png_ptr, PNG_FILTER_TYPE_DEFAULT, filters);
if (palette) {
color_type = PNG_COLOR_TYPE_PALETTE;
--
1.7.1
- [Qemu-devel] [PATCH v2 00/18] [PATCH v2 00/18] VNC Updates for 0.13, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 03/18] vnc: add lossy option, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 02/18] vnc: JPEG should be disabled if the client don't set tight quality, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 05/18] vnc: rename vnc-encoding-* vnc-enc-*, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 04/18] ui: move all ui components in ui/, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 07/18] vnc: tight: remove a memleak in send_jpeg_rect(), Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 01/18] vnc: tight: add JPEG and gradient subencoding with smooth image detection, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 09/18] vnc: tight: specific zlib level and filters for each compression level,
Corentin Chary <=
- [Qemu-devel] [PATCH v2 12/18] vnc: fix tight png memory leak, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 06/18] vnc: tight: don't forget do at the last color, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 16/18] vnc: tight: fix rgb_prepare_row, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 10/18] vnc: tight: stop using qdict for palette stuff, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 17/18] vnc: tight: split send_sub_rect, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 13/18] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 18/18] vnc: better default values for VNC options, Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 15/18] vnc: add missing lock for vnc_cursor_define(), Corentin Chary, 2010/07/07
- [Qemu-devel] [PATCH v2 08/18] vnc: tight add PNG encoding, Corentin Chary, 2010/07/07