qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support
Date: Sun, 24 Jan 2010 16:17:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1

On 01/24/2010 04:04 PM, Anthony Liguori wrote:
I agree with that, but we can look at async messages as a baseline protocol capability (thus no negotiation required), and the new command only enabled individual messages.


To be honest, I don't think there's really a need to mask individual messages. A client can always ignore messages it doesn't care about. There is no side effect of receiving a message so there is no functional implication of receiving messages you don't care about.

The only time it would matter is if we had a really high volume of messages. I'd suggest waiting until a message is introduced that could potentially have a high rate and then implement a mechanism to mask it. For now, it just adds unnecessary complexity.

Fair enough. But then, why can't all clients do that? Dropping an async notification is maybe one line of code.

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]