[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option
From: |
Gleb Natapov |
Subject: |
[Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR. |
Date: |
Mon, 12 Oct 2009 08:50:24 +0200 |
On Sun, Oct 11, 2009 at 11:53:56PM +0200, Michael S. Tsirkin wrote:
> On Sun, Oct 11, 2009 at 08:59:05PM +0200, Gleb Natapov wrote:
> > Bit 0 is the enable bit, which we not only don't want to set, but
> > it will stick and make us think it's an I/O port resource.
> >
> > Qemu pcbios commit 6ddb9f5c742b2b82b1755d7ec2a127f6e20e3806
> >
> > Signed-off-by: Gleb Natapov <address@hidden>
> > ---
> > src/pciinit.c | 8 +++++---
> > 1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/pciinit.c b/src/pciinit.c
> > index 1d0f784..29b3901 100644
> > --- a/src/pciinit.c
> > +++ b/src/pciinit.c
> > @@ -139,11 +139,13 @@ static void pci_bios_init_device(u16 bdf)
> > int ofs;
> > u32 val, size;
> >
> > - if (i == PCI_ROM_SLOT)
> > + if (i == PCI_ROM_SLOT) {
> > ofs = PCI_ROM_ADDRESS;
> > - else
> > + pci_config_writel(bdf, ofs, 0xfffffffe);
> > + } else {
> > ofs = PCI_BASE_ADDRESS_0 + i * 4;
> > - pci_config_writel(bdf, ofs, 0xffffffff);
> > + pci_config_writel(bdf, ofs, 0xffffffff);
> > + }
> > val = pci_config_readl(bdf, ofs);
> > if (val != 0) {
> > size = (~(val & ~0xf)) + 1;
>
> Hmm, eithe rinterpreet the spec strictly or loosely.
>
> If you implement the spec loosely, you can just write
> 0xfffffffe unconditionally: low bit is readonly for i/o and memory.
>
> Strict interpretation of spec requires that you write 0
> into reserved bits. These are bits 1 to 10 for ROM,
> and bit 1 for I/O.
>
>
Send patch with your favorite interpretation to qemu pcbios/seabios.
The regression concern from my previous mail applicable here as well.
--
Gleb.
- [Qemu-devel] [PATCH 1/5] Generate mptable unconditionally., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 5/5] Set the PCI base address to 0xf0000000., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 2/5] Enable power button event generation., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/11
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/11
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR.,
Gleb Natapov <=
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12