[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces |
Date: |
Sun, 5 Jul 2009 16:18:50 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Sun, Jul 05, 2009 at 03:07:06PM +0300, Avi Kivity wrote:
> On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
>>> With the braces comment I meant that while working on the code, you
>>> should update it to match CODING_STYLE:
>>> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) {
>>> return;
>>> }
>>>
>>
>> Yea ... it's probably better to do this all over the file, not piecewise,
>> though. No?
>>
>
> No, that just causes churn (and merge conflicts for me). Better to only
> fix if you have a patch that modifies the same place.
OK, I redid these patches with {}.
Even though the kernel style is better! ;)
--
MST