[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h |
Date: |
Sun, 15 Feb 2009 11:43:57 +0000 |
User-agent: |
Mutt/1.4.1i |
On Sat, Feb 14, 2009 at 04:09:31PM -0600, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >This patch moves the declaration for the VncState struct out of the
> >vnc.c file and into vnc.h. This is to prepare for next patches which
> >have the auth mechanisms implementated in separate vnc-auth-vencrypt.c
> >and vnc-auth-sasl.c files
> >
> >In doing this, I discovered that there is a pile of duplicated keymap
> >code statically compiled into all the console frontends. A couple of
> >trivial changes allowed this to be sanitized, so instead of doing
> >a #include "keymaps.c", duplicating all code, we can have a shared
> >keymaps.h file, and only compile code once.
> >
>
> It would be better if you split the keymap cleanup into a different patch.
Ok, easy enough todo. I'll post new patch to deal with this keymap change
first.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
- [Qemu-devel] PATCH: 0/7: Support SASL authentication in VNC server, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 3/7: Split out VNC TLS auth code to separate file, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 4/7: Add SASL authentication extension to VNC, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 5/7: Include auth credentials in 'info vnc', Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 6/7: Support simple ACL for client authorization, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 7/7: Add external persistent ACL file, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 0/7: Support SASL authentication in VNC server, Daniel P. Berrange, 2009/02/12
- Re: [Qemu-devel] PATCH: 0/7: Support SASL authentication in VNC server, Anthony Liguori, 2009/02/14