Re: [Qemu-devel] PATCH: 1/7: Extend 'info vnc' output to show client

[Daniel P. Berrange]

On Fri, Feb 13, 2009 at 12:30:59PM -0600, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >The current 'info vnc' monitor output just displays the VNC server address
> >as provided by the -vnc command line flag. This isn't particularly useful
> >since it doesn't tell you what VNC is actually listening on. eg, if you
> >use '-vnc :1' it is useful to know whether this translated to 
> >'0.0.0.0:5901'
> >or chose IPv6 ':::5901'.  It is also useful to know the address of the
> >client that is currently connected. It is also useful to know the active
> >authentication (if any).
> >
> >@@ -2518,3 +2626,11 @@ int vnc_display_open(DisplayState *ds, c
> > 
> >     return qemu_set_fd_handler2(vs->lsock, vnc_listen_poll, 
> >     vnc_listen_read, NULL, vs);
> > }
> >+
> >+/*
> >+ * Local variables:
> >+ *  c-indent-level: 4
> >+ *  c-basic-offset: 4
> >+ *  tab-width: 8
> >+ * End:
> >+ */
> >  
> 
> I'd prefer you not add this randomly in a patch.

Sorry, I added this to all the files I touched as QEMU's indentation rules
don't match the default emacs & emacs will thus mess up all the whitespace.
That said vnc.c already has alot of inconsistent whitespace :-( I'll strip
this chunk out of future patches before submission.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|