[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [6352] Fix character devices after DisplayState refacto
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [6352] Fix character devices after DisplayState refactoring |
Date: |
Fri, 16 Jan 2009 22:43:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> Revision: 6352
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6352
> Author: aliguori
> Date: 2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009)
>
> Log Message:
> -----------
> Fix character devices after DisplayState refactoring
>
> The DisplayState refactoring changed the machine init function to create a
> DisplayState for each VGA device instead of being passed an existing
> DisplayState. This change is critical to enable multiple graphics device
> support.
>
> Unfortunately, the serial/parallel/console code is structured today to run
> before machine init to fill out the CharDriverState table which the machine
> init function uses to determine whether to create the required devices.
>
> Since a 'vc' is a type of CharDriverState, the CharDriverState code requires
> that a DisplayState exist before it runs creating a circular dependency.
>
> To fix this, this splits the creation of the initial CharDriverState from
> the initialization of the text console. We can then in a second step
> associate
> a DisplayState with all TextConsoles. This allows us to create the
> CharDriverState's first, machine init, then associate the TextConsoles with
> a DisplayState.
>
> This code screams for more cleanup.
...and a fix to make the monitor show up on the second vc again. Any
immediate idea what went wrong?
Jan
signature.asc
Description: OpenPGP digital signature