[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] const / static (against current CVS)
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH] const / static (against current CVS) |
Date: |
Wed, 24 Aug 2005 15:49:04 +0100 |
User-agent: |
KMail/1.7.2 |
On Wednesday 24 August 2005 15:38, Andreas Mohr wrote:
> Hi,
>
> On Wed, Aug 24, 2005 at 02:41:44PM +0100, Paul Brook wrote:
> > > Probably more important is to make sure none constant data structures
> > > are done on the stack. There is no good reason why any code page
> > > should be read-write.
> >
> > Huh? this is nonsense.
>
> Uhoh, I seem to have managed to stir up a veritable hornet's net with my
> patch...
For the record this wasn't intended as a criticism of your patch. I think
adding const/static is a good idea for debugging/maintainability, even if it
doesn't give any actual performance benefits.
Paul