Re: [Qemu-devel] Experimental Cocoa Video Driver - Mousesupport and Keymap

[Pierre d'Herbemont]

Selon Mike Kronenberg <address@hidden>:

> Hello
>
> this patch provides initial Mouse- and better Keyboard support.
> There are still alot of things to do.

Thanks for the work Mike :)

> known Bugs and Workarounds:
>
> -  still no modifiers (help is apreciated)

in NSEvent there is a method called - (unsigned int)modifierFlags.

> -> no grab and ungrab (use alt-tab to switch)
>
> -  Mouseevents are only correcty passed, if the Cursor is within the
> qemu-Window, when it's activated (else the Mousedown/Mouseup are passed
> to the window, that was under the Cursor, when the qemu-Window is activated)

Probably polling for the event in NSEventTrackingRunLoopMode would help.

Also, I think your code should be cleaned up a bit. I think of all those
commented lines like:

@@ -253,16 +330,26 @@

     if (is_active_console(vga_console))
         vga_update_display();
+
+//    [NSCursor hide];
+//    CGAssociateMouseAndMouseCursorPosition ( FALSE );
+

which are not needed, and more confusing than really helpful. Also you define:

+
+static uint8_t modifiers_state[256]; //Mike
+

and you don't use it... I guess you should add this variable when the rest of
the code uses it.

Anyway, Keep up the good work.

Pierre.

PS: You should add the "[Patch]" keyword to the subject next time.