[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 00/21] block: remove aio_disable_external() API
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v5 00/21] block: remove aio_disable_external() API |
Date: |
Tue, 9 May 2023 13:51:38 -0400 |
On Thu, May 04, 2023 at 11:44:42PM +0200, Kevin Wolf wrote:
> Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben:
> > v5:
> > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin]
> > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event
> > before unrealizing the SCSIDevice [Kevin]
> > - Keep vhost-user-blk export .detach() callback so ctx is set to NULL
> > [Kevin]
> > - Narrow BdrvChildClass and BlockDriver drained_{begin/end/poll} callbacks
> > from
> > IO_OR_GS_CODE() to GLOBAL_STATE_CODE() [Kevin]
> > - Include Kevin's "block: Fix use after free in blockdev_mark_auto_del()" to
> > fix a latent bug that was exposed by this series
>
> I only just finished reviewing v4 when you had already sent v5, but it
> hadn't arrived yet. I had a few more comments on what are now patches
> 17, 18, 19 and 21 in v5. I think they all still apply.
I'm not sure which comments from v4 still apply. In my email client all
your replies were already read when I sent v5.
Maybe you can share the Message-Id of something I still need to address?
Thanks,
Stefan
signature.asc
Description: PGP signature
- [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd, (continued)
- [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 15/21] block/export: don't require AioContext lock around blk_exp_ref/unref(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 17/21] virtio: make it possible to detach host notifier from any thread, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 19/21] virtio-scsi: implement BlockDevOps->drained_begin(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 18/21] virtio-blk: implement BlockDevOps->drained_begin(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 20/21] virtio: do not set is_external=true on host notifiers, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 21/21] aio: remove aio_disable_external() API, Stefan Hajnoczi, 2023/05/04
- Re: [PATCH v5 00/21] block: remove aio_disable_external() API, Kevin Wolf, 2023/05/04
- Re: [PATCH v5 00/21] block: remove aio_disable_external() API,
Stefan Hajnoczi <=
- Re: [PATCH v5 00/21] block: remove aio_disable_external() API, Kevin Wolf, 2023/05/09