[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 20/21] virtio: do not set is_external=true on host notifiers
From: |
Stefan Hajnoczi |
Subject: |
[PATCH v5 20/21] virtio: do not set is_external=true on host notifiers |
Date: |
Thu, 4 May 2023 15:53:26 -0400 |
Host notifiers can now use is_external=false since virtio-blk and
virtio-scsi no longer rely on is_external=true for drained sections.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/virtio/virtio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 272d930721..9cdad7e550 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3491,7 +3491,7 @@ static void
virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx)
{
- aio_set_event_notifier(ctx, &vq->host_notifier, true,
+ aio_set_event_notifier(ctx, &vq->host_notifier, false,
virtio_queue_host_notifier_read,
virtio_queue_host_notifier_aio_poll,
virtio_queue_host_notifier_aio_poll_ready);
@@ -3508,14 +3508,14 @@ void virtio_queue_aio_attach_host_notifier(VirtQueue
*vq, AioContext *ctx)
*/
void virtio_queue_aio_attach_host_notifier_no_poll(VirtQueue *vq, AioContext
*ctx)
{
- aio_set_event_notifier(ctx, &vq->host_notifier, true,
+ aio_set_event_notifier(ctx, &vq->host_notifier, false,
virtio_queue_host_notifier_read,
NULL, NULL);
}
void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx)
{
- aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
+ aio_set_event_notifier(ctx, &vq->host_notifier, false, NULL, NULL, NULL);
/* Test and clear notifier before after disabling event,
* in case poll callback didn't have time to run. */
virtio_queue_host_notifier_read(&vq->host_notifier);
--
2.40.1
- Re: [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin(), (continued)
- [PATCH v5 14/21] block/export: rewrite vduse-blk drain code, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 15/21] block/export: don't require AioContext lock around blk_exp_ref/unref(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 17/21] virtio: make it possible to detach host notifier from any thread, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 19/21] virtio-scsi: implement BlockDevOps->drained_begin(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 18/21] virtio-blk: implement BlockDevOps->drained_begin(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 20/21] virtio: do not set is_external=true on host notifiers,
Stefan Hajnoczi <=
- [PATCH v5 21/21] aio: remove aio_disable_external() API, Stefan Hajnoczi, 2023/05/04
- Re: [PATCH v5 00/21] block: remove aio_disable_external() API, Kevin Wolf, 2023/05/04
- Re: [PATCH v5 00/21] block: remove aio_disable_external() API, Kevin Wolf, 2023/05/09