qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_ch


From: Hanna Reitz
Subject: Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().
Date: Tue, 22 Mar 2022 17:59:57 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 18.03.22 21:36, John Snow wrote:
Like qemu-img, qemu-io returning 0 should be the norm and not the
exception. Remove all calls to qemu_io_silent that just assert the
return code is zero (That's every last call, as it turns out), and
replace them with a normal qemu_io() call.

Signed-off-by: John Snow <jsnow@redhat.com>
---
  tests/qemu-iotests/216                        | 12 +++++-----
  tests/qemu-iotests/218                        |  5 ++---
  tests/qemu-iotests/224                        |  4 ++--
  tests/qemu-iotests/258                        | 12 +++++-----
  tests/qemu-iotests/298                        | 16 ++++++--------
  tests/qemu-iotests/310                        | 22 +++++++++----------
  tests/qemu-iotests/iotests.py                 | 16 --------------
  tests/qemu-iotests/tests/image-fleecing       |  4 ++--
  .../tests/mirror-ready-cancel-error           |  2 +-
  .../qemu-iotests/tests/stream-error-on-reset  |  4 ++--
  10 files changed, 39 insertions(+), 58 deletions(-)

qemu_io_silent_check() was unused anyway, right...?

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]