[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/15] iotests: make qemu_io_log() check return codes by defa
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 15/15] iotests: make qemu_io_log() check return codes by default |
|
Date: |
Mon, 21 Mar 2022 13:22:05 -0500 |
|
User-agent: |
NeoMutt/20211029-454-6adf99 |
On Fri, Mar 18, 2022 at 04:36:55PM -0400, John Snow wrote:
> Just like qemu_img_log(), upgrade qemu_io_log() to enforce a return code
> of zero by default.
>
> Affected tests: 242 245 255 274 303 307 nbd-reconnect-on-open
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 5 +++--
> tests/qemu-iotests/tests/nbd-reconnect-on-open | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
If I'm reading the commit message correctly, 'Affected tests' are all
tests that used qemu_io_log, but only nbd-reconnect-on-open needed a
change because it was the only one that explicitly tested a scenario
that triggers an expected non-zero status.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 12/15] iotests/migration-permissions: use assertRaises() for qemu_io() negative test, (continued)
- [PATCH 06/15] iotests: rebase qemu_io() on top of qemu_tool(), John Snow, 2022/03/18
- [PATCH 11/15] iotests/migration-permissions: fixup, John Snow, 2022/03/18
- [PATCH 15/15] iotests: make qemu_io_log() check return codes by default, John Snow, 2022/03/18
- [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check()., John Snow, 2022/03/18
- [PATCH 13/15] iotests: remove qemu_io_pipe_and_status(), John Snow, 2022/03/18