[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/22] block: add eMMC block device type
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 01/22] block: add eMMC block device type |
Date: |
Mon, 22 Feb 2021 13:19:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 2/22/21 9:20 AM, Sai Pavan Boddu wrote:
>> From: Vincent Palatin <vpalatin@chromium.org>
>>
>> Add new block device type.
>>
>> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
>> [SPB: Rebased over 5.1 version]
>> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>> ---
>> include/sysemu/blockdev.h | 1 +
>> blockdev.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/include/sysemu/blockdev.h b/include/sysemu/blockdev.h
>> index 3b5fcda..eefae9f 100644
>> --- a/include/sysemu/blockdev.h
>> +++ b/include/sysemu/blockdev.h
>> @@ -24,6 +24,7 @@ typedef enum {
>> */
>> IF_NONE = 0,
>> IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
>> + IF_EMMC,
>> IF_COUNT
>> } BlockInterfaceType;
>>
>> diff --git a/blockdev.c b/blockdev.c
>> index cd438e6..390d43c 100644
>> --- a/blockdev.c
>> +++ b/blockdev.c
>> @@ -83,6 +83,7 @@ static const char *const if_name[IF_COUNT] = {
>> [IF_SD] = "sd",
>> [IF_VIRTIO] = "virtio",
>> [IF_XEN] = "xen",
>> + [IF_EMMC] = "emmc",
>> };
>
> We don't need to introduce support for the legacy -drive magic.
>
> -device should be enough for this device, right?
External interface extensions need rationale: why do we want / need it?
The commit message neglects to provide one.
Even more so when the interface in question is in a state like -drive
is.
- Re: [PATCH v2 04/22] sd: emmc: update OCR fields for eMMC, (continued)
[PATCH v2 13/22] sd: emmc: Make ACMD41 illegal for mmc, Sai Pavan Boddu, 2021/02/22
[PATCH v2 07/22] sd: sdmmc-internal: Add command string for SEND_OP_CMD, Sai Pavan Boddu, 2021/02/22
[PATCH v2 09/22] sd: emmc: Update CMD1 definition for eMMC, Sai Pavan Boddu, 2021/02/22
[PATCH v2 03/22] sd: emmc: Add support for eMMC cards, Sai Pavan Boddu, 2021/02/22
[PATCH v2 18/22] sd: emmc: Subtract bootarea size from blk, Sai Pavan Boddu, 2021/02/22
[PATCH v2 01/22] block: add eMMC block device type, Sai Pavan Boddu, 2021/02/22
RE: [PATCH v2 01/22] block: add eMMC block device type, Sai Pavan Boddu, 2021/02/23
Re: [PATCH v2 01/22] block: add eMMC block device type, Stefan Hajnoczi, 2021/02/24
Re: [PATCH v2 01/22] block: add eMMC block device type, Cédric Le Goater, 2021/02/24
RE: [PATCH v2 01/22] block: add eMMC block device type, Sai Pavan Boddu, 2021/02/24
Re: [PATCH v2 01/22] block: add eMMC block device type, Cédric Le Goater, 2021/02/25
RE: [PATCH v2 01/22] block: add eMMC block device type, Sai Pavan Boddu, 2021/02/24