[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers |
Date: |
Tue, 20 Oct 2020 10:28:22 +0200 |
On Oct 19 11:17, Dmitry Fomichev wrote:
> With ZNS support in place, the majority of code in nvme_rw() has
> become read- or write-specific. Move these parts to two separate
> handlers, nvme_read() and nvme_write() to make the code more
> readable and to remove multiple is_write checks that so far existed
> in the i/o path.
>
> This is a refactoring patch, no change in functionality.
>
This makes a lot of sense, totally Acked, but it might be better to move
it ahead as a preparation patch? It would make the zoned patch easier on
the eye.
signature.asc
Description: PGP signature