[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only z
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones |
Date: |
Mon, 19 Oct 2020 13:42:30 +0200 |
On Oct 19 11:17, Dmitry Fomichev wrote:
> ZNS specification defines two zone conditions for the zones that no
> longer can function properly, possibly because of flash wear or other
> internal fault. It is useful to be able to "inject" a small number of
> such zones for testing purposes.
>
> This commit defines two optional device properties, "offline_zones"
> and "rdonly_zones". Users can assign non-zero values to these variables
> to specify the number of zones to be initialized as Offline or
> Read-Only. The actual number of injected zones may be smaller than the
> requested amount - Read-Only and Offline counts are expected to be much
> smaller than the total number of zones on a drive.
>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> ---
> hw/block/nvme-ns.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++
> hw/block/nvme-ns.h | 2 ++
> 2 files changed, 66 insertions(+)
>
> diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
> index 255ded2b43..d050f97909 100644
> --- a/hw/block/nvme-ns.c
> +++ b/hw/block/nvme-ns.c
> @@ -21,6 +21,7 @@
> #include "sysemu/sysemu.h"
> #include "sysemu/block-backend.h"
> #include "qapi/error.h"
> +#include "crypto/random.h"
>
> #include "hw/qdev-properties.h"
> #include "hw/qdev-core.h"
> @@ -132,6 +133,32 @@ static int nvme_calc_zone_geometry(NvmeNamespace *ns,
> Error **errp)
> return -1;
> }
>
> + if (ns->params.zd_extension_size) {
> + if (ns->params.zd_extension_size & 0x3f) {
> + error_setg(errp,
> + "zone descriptor extension size must be a multiple of 64B");
> + return -1;
> + }
> + if ((ns->params.zd_extension_size >> 6) > 0xff) {
> + error_setg(errp, "zone descriptor extension size is too large");
> + return -1;
> + }
> + }
Looks like this should have been added in the previous patch.
signature.asc
Description: PGP signature
- RE: [PATCH v7 04/11] hw/block/nvme: Support allocated CNS command variants, (continued)
- [PATCH v7 06/11] hw/block/nvme: Introduce max active and open zone limits, Dmitry Fomichev, 2020/10/18
- [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set, Dmitry Fomichev, 2020/10/18
- [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones, Dmitry Fomichev, 2020/10/18
- Re: [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones,
Klaus Jensen <=
- [PATCH v7 09/11] hw/block/nvme: Document zoned parameters in usage text, Dmitry Fomichev, 2020/10/18
- [PATCH v7 07/11] hw/block/nvme: Support Zone Descriptor Extensions, Dmitry Fomichev, 2020/10/18
- [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers, Dmitry Fomichev, 2020/10/18
- [PATCH v7 11/11] hw/block/nvme: Merge nvme_write_zeroes() with nvme_write(), Dmitry Fomichev, 2020/10/18
- Re: [PATCH v7 00/11] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set, Niklas Cassel, 2020/10/19