[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/16] meson: disable crypto tests are empty under win32
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 11/16] meson: disable crypto tests are empty under win32 |
Date: |
Wed, 9 Sep 2020 09:22:29 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote:
> On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
> > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote:
> > > Disable following tests on msys2/mingw
> > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
> > 'pkix_asn1_tab.c',
> > > tasn1, crypto],
> > > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c',
> > 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c',
> > > tasn1, crypto],
> > > 'test-io-channel-tls': ['io-channel-helpers.c',
> > 'crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c',
> > > tasn1, io, crypto]}
> >
> > Why ? GNUTLS is available on Windows and if it is enabled
> > at build time, then we should certainly be running the tests.
> >
>
> Don't know why., the header disable it totally.
Yes, I know the source disables it, because it creates various
files and no effort has been made to use WIndows filename
building code.
Given that it is already disabled in the source, why do we need
to disable it a second time in meson.build ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[PATCH 12/16] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/08
[PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/08
[PATCH 14/16] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/08
[PATCH 15/16] logging: Fixes memory leak in test-logging.c, Yonggang Luo, 2020/09/08