[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iotests/197: Fix for non-qcow2 formats
From: |
Thomas Huth |
Subject: |
Re: [PATCH] iotests/197: Fix for non-qcow2 formats |
Date: |
Tue, 28 Jul 2020 14:51:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 28/07/2020 14.21, Max Reitz wrote:
> While 197 is very much a qcow2 test, and it looks like the partial
> cluster case at the end (introduced in b0ddcbbb36a66a6) is specifically
> a qcow2 case, the whole test scripts actually marks itself to work with
> generic formats (and generic protocols, even).
>
> Said partial cluster case happened to work with non-qcow2 formats as
> well (mostly by accident), but 1855536256 broke that, because it sets
> the compat option, which does not work for non-qcow2 formats.
>
> So go the whole way and force IMGFMT=qcow2 and IMGPROTO=file, as done in
> other places in this test.
>
> Fixes: 1855536256eb0a5708b04b85f744de69559ea323
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/197 | 8 +++++---
> tests/qemu-iotests/197.out | 2 +-
> 2 files changed, 6 insertions(+), 4 deletions(-)
Thanks, that fixes the issue for me, indeed!
Tested-by: Thomas Huth <thuth@redhat.com>