Re: [PATCH 03/46] qdev: Smooth error checking of qdev_realize() & friends

[Markus Armbruster]

Eric Blake <eblake@redhat.com> writes:

> On 6/24/20 11:43 AM, Markus Armbruster wrote:
>> Convert
>>
>>      foo(..., &err);
>>      if (err) {
>>          ...
>>      }
>>
>> to
>>
>>      if (!foo(..., &err)) {
>>          ...
>>      }
>>
>> for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their
>> wrappers isa_realize_and_unref(), pci_realize_and_unref(),
>> sysbus_realize(), sysbus_realize_and_unref(), usb_realize_and_unref().
>> Coccinelle script:
>
> Automated patching is so much easier than manual :)

Except when Coccinelle dies with some weird error, or refuses to play
ball without any explanation at all :)

Coccinelle is both awesome and terrible!

>> Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
>> ARMSSE being used both as typedef and function-like macro there.
>> Convert manually.
>>
>> Eliminate error_propagate() that are now unnecessary.  Delete @err
>> that are now unused.  Clean up whitespace.
>
> Well, so there's still some manual stuff.  But that's okay; hopefully
> we don't have too many stragglers reintroduced via pending patches.

The first sentence is a leftover from an earlier, more manual version.
I'll delete it.

The manual stuff is really just deleting unused variables to make the
compiler happy, tidying up whitespace and breaking long lines to make
checkpatch happy, and tweak line breaks a bit more to make my reviewers
happy.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>>   65 files changed, 248 insertions(+), 768 deletions(-)
>
> Quite a big trim.  But I didn't spot any obvious problems.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!