[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type() |
Date: |
Thu, 25 Jun 2020 08:33:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/24/20 6:43 PM, Markus Armbruster wrote:
> Commit 2f262e06f0 lifted qdev_get_type() from qdev to object without
> renaming it accordingly. Do that now.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qom/object.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index b8aac074c2..f6e9f0e413 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -2359,7 +2359,7 @@ object_class_property_add_tm(ObjectClass *klass, const
> char *name,
> NULL, NULL, prop);
> }
>
> -static char *qdev_get_type(Object *obj, Error **errp)
> +static char *object_get_type(Object *obj, Error **errp)
> {
> return g_strdup(object_get_typename(obj));
> }
> @@ -2702,7 +2702,7 @@ void object_class_property_set_description(ObjectClass
> *klass,
>
> static void object_class_init(ObjectClass *klass, void *data)
> {
> - object_class_property_add_str(klass, "type", qdev_get_type,
> + object_class_property_add_str(klass, "type", object_get_type,
> NULL);
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 24/46] qapi: Smooth error checking manually, (continued)
- [PATCH 24/46] qapi: Smooth error checking manually, Markus Armbruster, 2020/06/24
- [PATCH 37/46] qom: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/06/24
- [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/06/24
- [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type(), Markus Armbruster, 2020/06/24
- [PATCH 25/46] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/06/24
- [PATCH 26/46] qapi: Smooth another visitor error checking pattern, Markus Armbruster, 2020/06/24
- [PATCH 18/46] qemu-option: Smooth error checking manually, Markus Armbruster, 2020/06/24
- [PATCH 39/46] qom: Smooth error checking manually, Markus Armbruster, 2020/06/24
- [PATCH 29/46] acpi: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/06/24