qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 26/46] qapi: Smooth another visitor error checking pattern


From: Eric Blake
Subject: Re: [PATCH 26/46] qapi: Smooth another visitor error checking pattern
Date: Wed, 24 Jun 2020 16:02:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 6/24/20 11:43 AM, Markus Armbruster wrote:
Convert

     visit_type_FOO(v, ..., &ptr, &err);
     ...
     if (err) {
        ...
     }

to

     visit_type_FOO(v, ..., &ptr, errp);
     ...
     if (!ptr) {
        ...
     }

for functions that set @ptr to non-null / null on success / error.

Eliminate error_propagate() that are now unnecessary.  Delete @err
that are now unused.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]