|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v7 11/48] nvme: refactor device realization |
Date: | Wed, 15 Apr 2020 09:55:14 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 4/15/20 9:25 AM, Klaus Birkelund Jensen wrote:
On Apr 15 09:14, Philippe Mathieu-Daudé wrote:Hi Klaus, This patch is a pain to review... Could you split it? I'd use one trivial patch for each function extracted from nvme_realize().Understood, I will split it up!
Thanks, that will help the review.As this series is quite big, I recommend you to split it, so part of it can get merged quicker and you don't have to carry tons of patches that scare reviewers/maintainers.
Suggestions: - 1: cleanups/refactors - 2: support v1.3 - 3: more refactors, strengthening code - 4: improve DMA & S/G - 5: support for multiple NS - 6: tests for multiple NS feature - 7: tests bus unplug/replug (idea) Or less :)
[Prev in Thread] | Current Thread | [Next in Thread] |