[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members
|
From: |
Klaus Birkelund Jensen |
|
Subject: |
Re: [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members |
|
Date: |
Wed, 15 Apr 2020 09:19:52 +0200 |
On Apr 15 09:10, Philippe Mathieu-Daudé wrote:
>
> "hw/block/nvme.h" should not pull in "block/nvme.h", both should include a
> common "hw/block/nvme_spec.h" (or better named). Not related to this patch
> although.
>
Hmm. It does pull in the "include/block/nvme.h" which is basically the
"nvme_spec.h" you are talking about. That file holds all spec related
structs that are shared between the VFIO based nvme driver
(block/nvme.c) and the emulated device (hw/block/nvme.c).
Isn't that what is intended?
- [PATCH v7 03/48] nvme: move device parameters to separate struct, (continued)
- [PATCH v7 03/48] nvme: move device parameters to separate struct, Klaus Jensen, 2020/04/15
- [PATCH v7 05/48] nvme: use constants in identify, Klaus Jensen, 2020/04/15
- [PATCH v7 06/48] nvme: refactor nvme_addr_read, Klaus Jensen, 2020/04/15
- [PATCH v7 09/48] nvme: add max_ioqpairs device parameter, Klaus Jensen, 2020/04/15
- [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members, Klaus Jensen, 2020/04/15
- [PATCH v7 07/48] nvme: add support for the abort command, Klaus Jensen, 2020/04/15
- [PATCH v7 08/48] nvme: fix pci doorbell size calculation, Klaus Jensen, 2020/04/15
- [PATCH v7 04/48] nvme: bump spec data structures to v1.3, Klaus Jensen, 2020/04/15
- [PATCH v7 01/48] nvme: rename trace events to nvme_dev, Klaus Jensen, 2020/04/15
- [PATCH v7 11/48] nvme: refactor device realization, Klaus Jensen, 2020/04/15