[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by comm
[Qemu-block] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335
Sun, 15 Sep 2019 23:36:52 +0300
Commit 8ac0f15f335 accidently broke the COW of non changed areas
of newly allocated clusters, when the write spans multiple clusters,
and needs COW both prior and after the write.
This results in 'after' COW area being encrypted with wrong
sector address, which render it corrupted.
CC: qemu-stable <address@hidden>
V2: grammar, spelling and code style fixes.
V3: more fixes after the review.
V4: addressed review comments from Max Reitz,
and futher refactored the qcow2_co_encrypt to just take full host and guest
which simplifies everything.
V5: reworked the patches so one of them fixes the bug
only and other one is just refactoring
V6: removed do_perform_cow_encrypt
V7: removed do_perform_cow_encrypt take two, this
time I hopefully did that correctly :-)
Also updated commit names and messages a bit
Maxim Levitsky (3):
block/qcow2: Fix corruption introduced by commit 8ac0f15f335
block/qcow2: refactor encryption code
qemu-iotests: Add test for bz #1745922
block/qcow2-cluster.c | 40 ++++++-----------
block/qcow2-threads.c | 63 ++++++++++++++++++++------
block/qcow2.c | 5 ++-
block/qcow2.h | 8 ++--
tests/qemu-iotests/263 | 91 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/263.out | 40 +++++++++++++++++
tests/qemu-iotests/group | 1 +
7 files changed, 202 insertions(+), 46 deletions(-)
create mode 100755 tests/qemu-iotests/263
create mode 100644 tests/qemu-iotests/263.out
- [Qemu-block] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335,
Maxim Levitsky <=