[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335
Date: Mon, 16 Sep 2019 15:39:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 15.09.19 22:36, Maxim Levitsky wrote:
> Commit 8ac0f15f335 accidently broke the COW of non changed areas
> of newly allocated clusters, when the write spans multiple clusters,
> and needs COW both prior and after the write.
> This results in 'after' COW area being encrypted with wrong
> sector address, which render it corrupted.
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922
> CC: qemu-stable <address@hidden>
> V2: grammar, spelling and code style fixes.
> V3: more fixes after the review.
> V4: addressed review comments from Max Reitz,
>     and futher refactored the qcow2_co_encrypt to just take full host and 
> guest offset
>     which simplifies everything.
> V5: reworked the patches so one of them fixes the bug
>     only and other one is just refactoring
> V6: removed do_perform_cow_encrypt
> V7: removed do_perform_cow_encrypt take two, this
>     time I hopefully did that correctly :-)
>     Also updated commit names and messages a bit

Luckily for you (maybe), Vladimir’s series doesn‘t quite pass the
iotests for me, so unfortunately (I find it unfortunate) I had to remove
it from my branch.  Thus, the conflicts are much more tame and I felt
comfortable taking the series to my branch (with the remaining trivial
conflicts resolved, and with Vladimir’s suggestion applied):



Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]