Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/15] monitor: Remove Monitor.c

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/15] monitor: Remove Monitor.c

From:	Markus Armbruster
Subject:	Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/15] monitor: Remove Monitor.cmd_table indirection
Date:	Fri, 14 Jun 2019 07:51:13 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Monitor.cmd_table is initialised to point to mon_cmds and never changed
> afterwards. We can remove the indirection and just reference mon_cmds
> directly instead.
>
> Signed-off-by: Kevin Wolf <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 01/15] monitor: Remove unused password prompting fields, Kevin Wolf, 2019/06/13
- [Qemu-block] [PATCH v3 03/15] monitor: Make MonitorQMP a child class of Monitor, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 03/15] monitor: Make MonitorQMP a child class of Monitor, Markus Armbruster, 2019/06/14
- [Qemu-block] [PATCH v3 02/15] monitor: Split monitor_init in HMP and QMP function, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 02/15] monitor: Split monitor_init in HMP and QMP function, Markus Armbruster, 2019/06/14
- [Qemu-block] [PATCH v3 05/15] monitor: Remove Monitor.cmd_table indirection, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 05/15] monitor: Remove Monitor.cmd_table indirection, Markus Armbruster <=
- [Qemu-block] [PATCH v3 06/15] monitor: Rename HMP command type and tables, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 06/15] monitor: Rename HMP command type and tables, Markus Armbruster, 2019/06/14
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 06/15] monitor: Rename HMP command type and tables, Markus Armbruster, 2019/06/14
- [Qemu-block] [PATCH v3 07/15] Move monitor.c to monitor/misc.c, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/15] Move monitor.c to monitor/misc.c, Markus Armbruster, 2019/06/14
    - Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/15] Move monitor.c to monitor/misc.c, Markus Armbruster, 2019/06/14
- [Qemu-block] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions, Kevin Wolf, 2019/06/13
  - Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions, Markus Armbruster, 2019/06/14
    - Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions, Kevin Wolf, 2019/06/14
- [Qemu-block] [PATCH v3 08/15] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c, Kevin Wolf, 2019/06/13

Prev by Date: Re: [Qemu-block] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface
Next by Date: Re: [Qemu-block] [Qemu-devel] [PATCH v3 06/15] monitor: Rename HMP command type and tables
Previous by thread: [Qemu-block] [PATCH v3 05/15] monitor: Remove Monitor.cmd_table indirection
Next by thread: [Qemu-block] [PATCH v3 06/15] monitor: Rename HMP command type and tables
Index(es):
- Date
- Thread