[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block patches
From: |
no-reply |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block patches |
Date: |
Sat, 12 May 2018 02:42:09 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/8] Block patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a35067253e block/file-posix: add x-check-page-cache=on|off option
c6c991d81f block/file-posix: implement bdrv_co_invalidate_cache() on Linux
3b9d04939d checkpatch: reduce MAINTAINERS update message frequency
92c27dd7e6 checkpatch: emit a warning on file add/move/delete
82e1381f3f checkpatch: ignore email headers better
63d8deac11 checkpatch: check utf-8 content from a commit log when it's missing
from charset
7ecaae4f83 checkpatch: add a --strict check for utf-8 in commit logs
ca525fa2f4 blockjob: drop block_job_pause/resume_all()
=== OUTPUT BEGIN ===
Checking PATCH 1/8: blockjob: drop block_job_pause/resume_all()...
Checking PATCH 2/8: checkpatch: add a --strict check for utf-8 in commit logs...
WARNING: line over 80 characters
#109: FILE: scripts/checkpatch.pl:1420:
+ WARN("8-bit UTF-8 used in possible commit log\n" .
$herecurr);
total: 0 errors, 1 warnings, 66 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/8: checkpatch: check utf-8 content from a commit log when it's
missing from charset...
Checking PATCH 4/8: checkpatch: ignore email headers better...
Checking PATCH 5/8: checkpatch: emit a warning on file add/move/delete...
WARNING: line over 80 characters
#51: FILE: scripts/checkpatch.pl:1397:
+ ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/
&&
ERROR: line over 90 characters
#54: FILE: scripts/checkpatch.pl:1400:
+ WARN("added, moved or deleted file(s), does MAINTAINERS
need updating?\n" . $herecurr);
total: 1 errors, 1 warnings, 24 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/8: checkpatch: reduce MAINTAINERS update message frequency...
Checking PATCH 7/8: block/file-posix: implement bdrv_co_invalidate_cache() on
Linux...
WARNING: architecture specific defines should be avoided
#52: FILE: block/file-posix.c:2255:
+#if defined(__linux__)
total: 0 errors, 1 warnings, 70 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/8: block/file-posix: add x-check-page-cache=on|off option...
WARNING: line over 80 characters
#47: FILE: block/file-posix.c:423:
+ .help = "check that page cache was dropped on live migration
(default: off)"
WARNING: architecture specific defines should be avoided
#120: FILE: block/file-posix.c:2264:
+#if defined(__linux__)
total: 0 errors, 2 warnings, 185 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-block] [PULL 0/8] Block patches, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 2/8] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 1/8] blockjob: drop block_job_pause/resume_all(), Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 4/8] checkpatch: ignore email headers better, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 6/8] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 5/8] checkpatch: emit a warning on file add/move/delete, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 7/8] block/file-posix: implement bdrv_co_invalidate_cache() on Linux, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 8/8] block/file-posix: add x-check-page-cache=on|off option, Stefan Hajnoczi, 2018/05/12
- Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block patches,
no-reply <=
- Re: [Qemu-block] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14
- Re: [Qemu-block] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14