[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 3/8] checkpatch: check utf-8 content from a commit lo
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-block] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset |
Date: |
Sat, 12 May 2018 10:28:19 +0100 |
From: Pasi Savanainen <address@hidden>
Check that a commit log doesn't contain UTF-8 when a mail header
explicitly defines a different charset, like
'Content-Type: text/plain; charset="us-ascii"'
Signed-off-by: Pasi Savanainen <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andrew Morton <address@hidden>
Signed-off-by: Linus Torvalds <address@hidden>
Message-id: address@hidden
Cc: Joe Perches <address@hidden>
Cc: Andy Whitcroft <address@hidden>
Signed-off-by: Andrew Morton <address@hidden>
Signed-off-by: Linus Torvalds <address@hidden>
(cherry picked from commit fa64205df9dfd7b7662cc64a7e82115c00e428e5)
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
scripts/checkpatch.pl | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c667d085ae..25bf43bad0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1186,6 +1186,8 @@ sub process {
my $in_header_lines = 1;
my $in_commit_log = 0; #Scanning lines before patch
+ my $non_utf8_charset = 0;
+
our @report = ();
our $cnt_lines = 0;
our $cnt_error = 0;
@@ -1414,8 +1416,15 @@ sub process {
$in_commit_log = 1;
}
-# Still not yet in a patch, check for any UTF-8
- if ($in_commit_log && $realfile =~ /^$/ &&
+# Check if there is UTF-8 in a commit log when a mail header has explicitly
+# declined it, i.e defined some charset where it is missing.
+ if ($in_header_lines &&
+ $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
+ $1 !~ /utf-8/i) {
+ $non_utf8_charset = 1;
+ }
+
+ if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ &&
$rawline =~ /$NON_ASCII_UTF8/) {
WARN("8-bit UTF-8 used in possible commit log\n" .
$herecurr);
}
--
2.17.0
- [Qemu-block] [PULL 0/8] Block patches, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 2/8] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 1/8] blockjob: drop block_job_pause/resume_all(), Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 4/8] checkpatch: ignore email headers better, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset,
Stefan Hajnoczi <=
- [Qemu-block] [PULL 6/8] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 5/8] checkpatch: emit a warning on file add/move/delete, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 7/8] block/file-posix: implement bdrv_co_invalidate_cache() on Linux, Stefan Hajnoczi, 2018/05/12
- [Qemu-block] [PULL 8/8] block/file-posix: add x-check-page-cache=on|off option, Stefan Hajnoczi, 2018/05/12
- Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block patches, no-reply, 2018/05/12
- Re: [Qemu-block] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14
- Re: [Qemu-block] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14