[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove |
Date: |
Thu, 18 Jan 2018 16:43:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> tests/qemu-iotests/201 | 159
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/201.out | 5 ++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 165 insertions(+)
> create mode 100644 tests/qemu-iotests/201
> create mode 100644 tests/qemu-iotests/201.out
>
> +
> + def assertExistingClients(self, result):
> + self.assert_qmp(result, 'error/desc',
> + "NBD export 'exp' has 1 active connection. To force "
> + "remove it (and hard disconnect clients) use "
> + "mode='hard'")
Needs tweaking if we massage the error message earlier in the series.
I'm still worried that this test may fail spuriously due to a hard-coded
port, but some testing is better than none, and if the CI engines don't
immediately reject it, whoever first encounters it will be nice and let
us know.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 0/6] nbd export qmp interface, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 1/6] qapi: add name parameter to nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- Re: [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove,
Eric Blake <=
- Re: [Qemu-block] [PATCH v2 0/6] nbd export qmp interface, Eric Blake, 2018/01/18