[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add |
Date: |
Thu, 18 Jan 2018 21:11:19 +0300 |
Support name parameter for HMP too.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
hmp.c | 3 ++-
hmp-commands.hx | 9 +++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/hmp.c b/hmp.c
index 37972f8322..964cff8aed 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2236,10 +2236,11 @@ exit:
void hmp_nbd_server_add(Monitor *mon, const QDict *qdict)
{
const char *device = qdict_get_str(qdict, "device");
+ const char *name = qdict_get_try_str(qdict, "name");
bool writable = qdict_get_try_bool(qdict, "writable", false);
Error *local_err = NULL;
- qmp_nbd_server_add(device, false, NULL, true, writable, &local_err);
+ qmp_nbd_server_add(device, name != NULL, name, true, writable, &local_err);
if (local_err != NULL) {
hmp_handle_error(mon, &local_err);
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 6d5ebdf6ab..cad9a9a238 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1553,8 +1553,8 @@ ETEXI
{
.name = "nbd_server_add",
- .args_type = "writable:-w,device:B",
- .params = "nbd_server_add [-w] device",
+ .args_type = "name:-n,writable:-w,device:B",
+ .params = "nbd_server_add [-n] [-w] device",
.help = "export a block device via NBD",
.cmd = hmp_nbd_server_add,
},
@@ -1562,8 +1562,9 @@ STEXI
@item nbd_server_add @var{device}
@findex nbd_server_add
Export a block device through QEMU's NBD server, which must be started
-beforehand with @command{nbd_server_start}. The @option{-w} option makes the
-exported device writable too.
+beforehand with @command{nbd_server_start}. The @option{-n} option sets export
+name. If @option{-n} option is unspecified, the @var{device} parameter is used.
+The @option{-w} option makes the exported device writable too.
ETEXI
{
--
2.11.1
- [Qemu-block] [PATCH v2 0/6] nbd export qmp interface, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 1/6] qapi: add name parameter to nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-block] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18