[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH 1/9] blockdev: hold AioContext for bdrv_unref() in e

From: Stefan Hajnoczi
Subject: [Qemu-block] [PATCH 1/9] blockdev: hold AioContext for bdrv_unref() in external_snapshot_clean()
Date: Tue, 5 Dec 2017 10:41:33 +0000

bdrv_unref() requires the AioContext lock because bdrv_flush() uses
BDRV_POLL_WHILE(), which assumes the AioContext is currently held.  If
BDRV_POLL_WHILE() runs without AioContext held the
pthread_mutex_unlock() call in aio_context_release() fails.

This patch moves bdrv_unref() into the AioContext locked region to solve
the following pthread_mutex_unlock() failure:

  #0  0x00007f566181969b in raise () at /lib64/libc.so.6
  #1  0x00007f566181b3b1 in abort () at /lib64/libc.so.6
  #2  0x00005592cd590458 in error_exit (err=<optimized out>, address@hidden 
<__func__.23977> "qemu_mutex_unlock") at util/qemu-thread-posix.c:36
  #3  0x00005592cd96e738 in qemu_mutex_unlock (address@hidden) at 
  #4  0x00005592cd969b69 in aio_context_release (address@hidden) at 
  #5  0x00005592cd8ead78 in bdrv_flush (address@hidden) at block/io.c:2478
  #6  0x00005592cd89df30 in bdrv_close (bs=0x5592cfa87210) at block.c:3207
  #7  0x00005592cd89df30 in bdrv_delete (bs=0x5592cfa87210) at block.c:3395
  #8  0x00005592cd89df30 in bdrv_unref (bs=0x5592cfa87210) at block.c:4418
  #9  0x00005592cd6b7f86 in qmp_transaction (dev_list=<optimized out>, 
has_props=<optimized out>, props=<optimized out>, address@hidden) at 

Signed-off-by: Stefan Hajnoczi <address@hidden>
 blockdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blockdev.c b/blockdev.c
index 56a6b24a0b..3c8d994ced 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1812,8 +1812,8 @@ static void external_snapshot_clean(BlkActionState 
                              DO_UPCAST(ExternalSnapshotState, common, common);
     if (state->aio_context) {
-        aio_context_release(state->aio_context);
+        aio_context_release(state->aio_context);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]