[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 03/13] nbd: rename some simple-request relate
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_ |
Date: |
Thu, 12 Oct 2017 16:26:45 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> To be consistent when their _structured_analogs will be introduced.
space before analogs
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/nbd-internal.h | 2 +-
> nbd/client.c | 4 ++--
> nbd/server.c | 12 ++++++------
> nbd/trace-events | 2 +-
> tests/qemu-iotests/nbd-fault-injector.py | 4 ++--
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
> +++ b/nbd/trace-events
> @@ -54,7 +54,7 @@ nbd_receive_request(uint32_t magic, uint16_t flags,
> uint16_t type, uint64_t from
> nbd_send_reply(int32_t error, uint64_t handle) "Sending response to client:
> { .error = %" PRId32 ", handle = %" PRIu64 " }"
> nbd_blk_aio_attached(const char *name, void *ctx) "Export %s: Attaching
> clients to AIO context %p\n"
> nbd_blk_aio_detach(const char *name, void *ctx) "Export %s: Detaching
> clients from AIO context %p\n"
> -nbd_co_send_reply(uint64_t handle, uint32_t error, int len) "Send reply:
> handle = %" PRIu64 ", error = %" PRIu32 ", len = %d"
> +nbd_co_send_simple_reply(uint64_t handle, uint32_t error, int len) "Send
> reply: handle = %" PRIu64 ", error = %" PRIu32 ", len = %d"
I'd also insert 'simple' in the log message.
Interesting that we trace when the server sends a simple message, but
the client does not (yet) trace which type of message it receives; but
that can be for later patches (I haven't checked if you already added it
later in this series)
Changes are small enough that I can make them as part of queueing them
on my NBD list, with:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request, (continued)
- [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 10/13] nbd/client: refactor nbd_receive_starttls, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 08/13] nbd: header constants indenting, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_, Vladimir Sementsov-Ogievskiy, 2017/10/12
- Re: [Qemu-block] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_,
Eric Blake <=
- [Qemu-block] [PATCH v3 12/13] nbd/client: prepare nbd_receive_reply for structured reply, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 05/13] nbd/server: do not use NBDReply structure, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 13/13] nbd: Minimal structured read for client, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 09/13] nbd: Minimal structured read for server, Vladimir Sementsov-Ogievskiy, 2017/10/12