[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reu
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c |
Date: |
Fri, 13 Oct 2017 13:47:58 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> include/block/nbd.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> nbd/nbd-internal.h | 25 -------------------------
> nbd/client.c | 32 --------------------------------
> 3 files changed, 48 insertions(+), 57 deletions(-)
>
> +static inline int nbd_errno_to_system_errno(int err)
> +{
> + switch (err) {
> + case NBD_SUCCESS:
> + return 0;
> + case NBD_EPERM:
> + return EPERM;
> + case NBD_EIO:
> + return EIO;
> + case NBD_ENOMEM:
> + return ENOMEM;
> + case NBD_ENOSPC:
> + return ENOSPC;
> + case NBD_ESHUTDOWN:
> + return ESHUTDOWN;
> + case NBD_EINVAL:
> + return EINVAL;
> + }
> +
> + return EINVAL;
> +}
This lacks a trace...
> +++ b/nbd/client.c
> @@ -22,38 +22,6 @@
> #include "trace.h"
> #include "nbd-internal.h"
>
> -static int nbd_errno_to_system_errno(int err)
> -{
> - int ret;
> - switch (err) {
> - case NBD_SUCCESS:
> - ret = 0;
> - break;
> - case NBD_EPERM:
> - ret = EPERM;
> - break;
> - case NBD_EIO:
> - ret = EIO;
> - break;
> - case NBD_ENOMEM:
> - ret = ENOMEM;
> - break;
> - case NBD_ENOSPC:
> - ret = ENOSPC;
> - break;
> - case NBD_ESHUTDOWN:
> - ret = ESHUTDOWN;
> - break;
> - default:
> - trace_nbd_unknown_error(err);
> - /* fallthrough */
> - case NBD_EINVAL:
...that was present here. And you didn't do straight code motion, but
modified things on the way (hence why checkpatch complained that your
more concise version is suspicious with regards to returning positive
errno). Does the function still need to be static inline, or should we
just declare a prototype in the header and put the function itself in
nbd/common.c?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 07/13] nbd-server: simplify reply transmission, (continued)
- [Qemu-block] [PATCH v3 07/13] nbd-server: simplify reply transmission, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 02/13] block/nbd-client: refactor nbd_co_receive_reply, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 06/13] nbd/server: refactor nbd_co_send_simple_reply parameters, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 10/13] nbd/client: refactor nbd_receive_starttls, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 08/13] nbd: header constants indenting, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 12/13] nbd/client: prepare nbd_receive_reply for structured reply, Vladimir Sementsov-Ogievskiy, 2017/10/12