[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucke
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types |
Date: |
Tue, 08 Aug 2017 17:21:45 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 08 Aug 2017 05:11:27 PM CEST, Eric Blake wrote:
>> Why is this marked for-2.10? Does it fix a bug?
>
> Theoretically, converting between int64_t and double loses precision
> on any values larger than 2^53. In all practicality, though, if you
> expect throttling to be precise through 2^53 (approximately 16 orders
> of magnitude), you're crazy.
You cannot, THROTTLE_VALUE_MAX is set to 10^15, which is smaller than
2^50.
> So I'm also having a hard time seeing this as 2.10 material.
Right, as I said that was a wrong assumption from my side :) No need for
this in 2.10.
Berto