[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185 |
Date: |
Tue, 8 Aug 2017 17:16:00 +0200 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 08.08.2017 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 08.08.2017 18:07, Eric Blake wrote:
> > On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
> >
> > > > > > Throttling "guaranties" that there will not be more than one
> > > > > > request. But
> > > > > > what prevent less than one, i.e. zero, like in my reproduction?
> > > > > Yes, I understand. Can we somehow make sure that at least one
> > > > > iteration
> > > > > is made? I'd really like to keep the functional test for block job
> > > > > throttling. I suppose a simple 'sleep 0.1' would do the trick, though
> > > > > it's not very clean.
> > > > >
> > > > > Kevin
> > > >
> > > > I've started with 'sleep 0.5', now there are >100 successful
> > > > iterations... The other way is to check in test that there was 0 or 1
> > > > requests, but for this it looks better to rewrite it in python.
> > > >
> > > >
> > > is sleep for ms portable?
> > Sadly, sub-second sleep is a GNU coreutils feature; I suspect the BSD
> > machines may fail to parse it. (Of course, we could do some sort of
> > 'sleep $SMALL', where $SMALL is 0.5 if sleep supports it, and 1 otherwise).
> >
> sleep for 1 second may lead to more then one request done before qemu quite.
_supported_os Linux
So do we really care about portability? And are all the other test cases
working on the BSDs?
Kevin
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] iotests: fix 185, (continued)
Re: [Qemu-block] [PATCH] iotests: fix 185, Kevin Wolf, 2017/08/07
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Kevin Wolf, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Eric Blake, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185,
Kevin Wolf <=
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Eric Blake, 2017/08/08